Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore/refactor structure #431

Merged
merged 7 commits into from
Sep 22, 2023
Merged

Chore/refactor structure #431

merged 7 commits into from
Sep 22, 2023

Conversation

kiwiidb
Copy link
Contributor

@kiwiidb kiwiidb commented Sep 22, 2023

This PR refactors a bit the file/package structure of the repo based on https://go.dev/doc/modules/layout.
While we can do much more refactoring to introduce more best practices, this is a first good step. It does the following things:

  • Introduce cmd/.. packages to hold the main commands: the server itself and the scripts that can be used to do ops tasks: payment reconciliation, invoice republishing to rabbitmq.
  • Make the LND package not depend on the service package, it now needs just its own config.
  • Move the code regarding the echo server to the lib/transport package.
  • Update the Dockerfile to also add the utility binaries.

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

Merging #431 (f1a8442) into main (6925458) will decrease coverage by 1.43%.
Report is 4 commits behind head on main.
The diff coverage is 7.69%.

@@            Coverage Diff             @@
##             main     #431      +/-   ##
==========================================
- Coverage   58.78%   57.35%   -1.43%     
==========================================
  Files          51       54       +3     
  Lines        3557     3642      +85     
==========================================
- Hits         2091     2089       -2     
- Misses       1245     1332      +87     
  Partials      221      221              
Files Changed Coverage Δ
integration_tests/util.go 87.87% <ø> (-0.13%) ⬇️
lib/service/background_routines.go 0.00% <0.00%> (ø)
lib/service/config.go 0.00% <ø> (ø)
lnd/config.go 0.00% <0.00%> (ø)
lnd/ln_client.go 0.00% <0.00%> (ø)
rabbitmq/rabbitmq.go 52.75% <100.00%> (ø)

@kiwiidb kiwiidb merged commit d085a95 into main Sep 22, 2023
2 of 5 checks passed
@kiwiidb kiwiidb deleted the chore/refactor-structure branch September 22, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant